feat(prospective-parachains): Implement HandleIntroduceSecondedCandidate
#4350
Conversation
- Added: Candidate Entry - (inclusion_emulator): Added ProspectiveCandidate, Modification error and Fragment Validity error
rebonat0
requested review from
EclesioMeloJunior,
jimjbrettj,
timwu20 and
kishansagathiya
as code owners
|
|
|
|
EclesioMeloJunior
changed the title
HandleIntroduceSecondedCandidate
|
should wait the merge of branch of #4337 |
…uce_seconded_candidate
…ssamer into eclesio/fragment-chain-impl
|
@rebonat0 this PR is unblocked now, sorry for the long delay! |
…uce_seconded_candidate
EclesioMeloJunior
changed the base branch from
eclesio/fragment-chain-impl
to
feat/parachain
@rebonat0 please sign the CLA |
| perRelayParent: make(map[common.Hash]*relayParentData), | ||
| activeLeaves: make(map[common.Hash]bool), | ||
| implicitView: nil, // TODO: currently there's no implementation for ImplicitView, reference is: | ||
| // https://github.com/ChainSafe/gossamer/blob/main/lib/prospective_parachains/view.go#L10 |
There was a problem hiding this comment.
URL returns 404. Was this meant to be https://github.com/paritytech/polkadot-sdk/blob/028e61be43f05f6f6c88c5cca94160f8db075585/polkadot/node/subsystem-util/src/backing_implicit_view.rs#L40?
|
|
||
| if err != nil { | ||
| logger.Tracef("hashing candidate: %s", err.Error()) | ||
| response <- false |
There was a problem hiding this comment.
Usually the writer closes the channel when it is done. Will this channel be used somewhere else as well or should it be closed here?
If it should be closed here, I suggest adding defer close(response) at the top of the function.
If you are unsure we can leave it as is and figure it out later. In that case please add a TODO comment somewhere.
Co-authored-by: Haiko Schol <[email protected]>
Co-authored-by: Haiko Schol <[email protected]>
Changes
This PR introduces the
HandleIntroduceSecondedCandidatefunc toprospectiveparachainspackage.Notes:
currently there's no implementation for ImplicitView, reference is:
polkadot-sdk reference
Tests
go test -timeout 30s github.com/ChainSafe/gossamer/dot/parachain/prospective-parachainsIssues
closes #4308